----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review169468 -----------------------------------------------------------
LGTM but for one non-functional issue. I believe it might make sense to combine this into one change set with the previous patch since we e.g., likely wouldn't be interested in backporting. Maybe @adam-mesos has some idea. src/tests/authorization_tests.cpp Lines 1171 (patched) <https://reviews.apache.org/r/57474/#comment241822> The blocks you add here should probably be documented in the same fat style currently used in this file. Here and elsewhere in this patch. - Benjamin Bannier On March 13, 2017, 4:35 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57474/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 4:35 p.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Adds tests for each of the actions which support hierarchical roles. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 42edecc794b71a00ca32d26ae9b74e9f3ef97510 > > > Diff: https://reviews.apache.org/r/57474/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
