> On March 20, 2017, 10:28 a.m., Benjamin Bannier wrote: > > LGTM but for one non-functional issue. > > > > I believe it might make sense to combine this into one change set with the > > previous patch since we e.g., likely wouldn't be interested in backporting. > > Maybe @adam-mesos has some idea. > > Alexander Rojas wrote: > I'm inclined to agree with you. Other reviewers in the past have > requested to break patches betweent he functional changes and tests. Let's > @adam-mesos give us a directive here.
Either way's fine with me. It's nice having them in separate reviews so (as a reviewer) I can review all but the tests in my first pass, but I also do that based on filenames in a combined impl+tests patch. As committer, though I may stamp a ShipIt on the impl patch while still polishing up the test patch, I can still choose to wait to commit both in the same push. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57474/#review169468 ----------------------------------------------------------- On April 11, 2017, 1:47 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57474/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 1:47 a.m.) > > > Review request for mesos, Adam B and Benjamin Bannier. > > > Bugs: MESOS-7026 > https://issues.apache.org/jira/browse/MESOS-7026 > > > Repository: mesos > > > Description > ------- > > Adds tests for each of the actions which support hierarchical roles. > > > Diffs > ----- > > src/tests/authorization_tests.cpp 3e18c70738b6b7098f37fadebb799a596e76452d > > > Diff: https://reviews.apache.org/r/57474/diff/4/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
