> On March 13, 2017, 9:23 p.m., Alexander Rukletsov wrote: > > docs/upgrades.md > > Lines 261-263 (patched) > > <https://reviews.apache.org/r/57472/diff/3/?file=1661191#file1661191line261> > > > > Let's say how they should update the cluster. > > > > ``` > > * When upgrading a Mesos cluster that uses the `set_quotas` or > > `remove_quotas` ACLs, the operator should first upgrade the Mesos binaries. > > At this point, the deprecated ACLs will still be enforced. After the > > upgrade has been verified, the operator should replace deprecated values > > for `set_quotas` and `remove_quotas` with equivalent values for > > `update_quotas`; > > ``` > > Alexander Rojas wrote: > Don't think we do that in the document. I can make a summary of what you > said. However, don't you need to first upgrade the ACLs (we are deleting > support from them) and then the binaries?
I think this is exactly why this document exists: to help operators do the right thing : ). Regarding the process, you're right: new binaries will reject old ACLs, hence we should swap the steps. Another proof this message is useful! > On March 13, 2017, 9:23 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/acls.proto > > Lines 406-409 (original) > > <https://reviews.apache.org/r/57472/diff/3/?file=1661192#file1661192line406> > > > > Do we usually keep a comment saying that tags `9` and `10` are not > > allowed to be used any more? > > Alexander Rojas wrote: > I don't think we do, but it does sound important. May I ask you to figure out if we already have a policy here and if not, propose one and share it on the dev list? I can hardly imagine this is the last time we remove a field from a proto : ) - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/#review168830 ----------------------------------------------------------- On March 21, 2017, 1:28 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57472/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 1:28 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier. > > > Bugs: MESOS-7259 > https://issues.apache.org/jira/browse/MESOS-7259 > > > Repository: mesos > > > Description > ------- > > The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation > more than six months ago, where they were replaced for the more > convenient `UpdateQuota` ACL. The deprecation cycle for these actions > is finally due while at the same time removing will make easier to > implement the hierarchical role feature in a generic way. > > > Diffs > ----- > > CHANGELOG 09fbf03b4274098e8051460bf9d7e9dac4acc987 > docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 > include/mesos/authorizer/acls.proto > e75e1879435f1c2bce47a86e9feebf9d051e969b > src/authorizer/local/authorizer.cpp > be8037299601427e5d5e79f58f77eea3f89579d0 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 > src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f > src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 > > > Diff: https://reviews.apache.org/r/57472/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
