----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57472/#review170272 -----------------------------------------------------------
Fix it, then Ship it! Minor clarification, otherwise great. CHANGELOG Lines 7-8 (patched) <https://reviews.apache.org/r/57472/#comment243071> This change is only applicable to the local authorizer, right? Other authorizers probably don't use `--acls`. - Adam B On March 21, 2017, 6:28 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57472/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 6:28 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, and Benjamin Bannier. > > > Bugs: MESOS-7259 > https://issues.apache.org/jira/browse/MESOS-7259 > > > Repository: mesos > > > Description > ------- > > The ACLs `SetQuota` and `RemoveQuota` where marked for deprecation > more than six months ago, where they were replaced for the more > convenient `UpdateQuota` ACL. The deprecation cycle for these actions > is finally due while at the same time removing will make easier to > implement the hierarchical role feature in a generic way. > > > Diffs > ----- > > CHANGELOG 09fbf03b4274098e8051460bf9d7e9dac4acc987 > docs/upgrades.md e7f95aadeee330b3a9dbafc0f716c13df1bc8252 > include/mesos/authorizer/acls.proto > e75e1879435f1c2bce47a86e9feebf9d051e969b > src/authorizer/local/authorizer.cpp > be8037299601427e5d5e79f58f77eea3f89579d0 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 > src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f > src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 > > > Diff: https://reviews.apache.org/r/57472/diff/5/ > > > Testing > ------- > > `make check` > > > Thanks, > > Alexander Rojas > >
