----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57836/#review169699 -----------------------------------------------------------
Patch looks great! Reviews applied: [57836] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 22, 2017, 12:38 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57836/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 12:38 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-7281 > https://issues.apache.org/jira/browse/MESOS-7281 > > > Repository: mesos > > > Description > ------- > > Patch in r/57108 introduced framework info updates. When a patched agent > is used with not patched master it will accept a default-intialized > framework info with an empty framework ID. This will cause an agent > abort when it tries to launch a new task for the updated framework. This > change fixes it. > > > Diffs > ----- > > src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b > > > Diff: https://reviews.apache.org/r/57836/diff/1/ > > > Testing > ------- > > Ran `make check`. Verified manually by launching a task, forcing a framework > to failover to make the master send an `UpdateFrameworkMessage` and launching > more tasks. > > > Thanks, > > Ilya Pronin > >
