----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57836/#review169913 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On March 23, 2017, 6:12 a.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57836/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 6:12 a.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Bugs: MESOS-7281 > https://issues.apache.org/jira/browse/MESOS-7281 > > > Repository: mesos > > > Description > ------- > > The commit 4912f341dce12f10b43fe82db20086032391e95a introduced a new > `framework_info` field in the `UpdateFrameworkMessage` sent from the > master to the agent. Unfortunately, the agent code unconditionally > uses the new field, which results in a default-intialized > `FrameworkInfo` when a new agent is receiving the message from an > old master. This leads to an agent abort when it subsequently tries > to launch a new task for the updated framework. > > This fixes the issue by ignoring the field if unset. > > > Diffs > ----- > > src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb > src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b > src/tests/slave_recovery_tests.cpp 09bfa75dd03fa19fba2c9dee15d29d703ca02f29 > > > Diff: https://reviews.apache.org/r/57836/diff/2/ > > > Testing > ------- > > Ran `make check`. Verified manually by launching a task, forcing a framework > to failover to make the master send an `UpdateFrameworkMessage` and launching > more tasks. > > > Thanks, > > Ilya Pronin > >
