----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57763/#review169820 -----------------------------------------------------------
src/slave/containerizer/mesos/launch.cpp Lines 654-656 (original), 654-656 (patched) <https://reviews.apache.org/r/57763/#comment242464> With the introduction of `Secret` into `Environment::Variable` this is technically not correct anymore. I understand changing this is outside the scope of the patch, but please leave a TODO. src/slave/containerizer/mesos/launch.cpp Lines 662-663 (original), 662-663 (patched) <https://reviews.apache.org/r/57763/#comment242465> Keeping in mind recent introduction of `Secret` into `Environment::Variable`, you should probably also check whether the type is the same. But not before this code snippet becomes `Secret`-aware in general. src/slave/containerizer/mesos/launch.cpp Lines 663-666 (original), 663-664 (patched) <https://reviews.apache.org/r/57763/#comment242463> Since we remove data which might be useful to debug things, how about leaving a TODO for restoring it back once https://issues.apache.org/jira/browse/MESOS-7292 is resolved? - Alexander Rukletsov On March 20, 2017, 2:51 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57763/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 2:51 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, Jie > Yu, and Joseph Wu. > > > Bugs: MESOS-7264 > https://issues.apache.org/jira/browse/MESOS-7264 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 8658525b00e78bed9227d6d400eccccae2cf25dd > > > Diff: https://reviews.apache.org/r/57763/diff/1/ > > > Testing > ------- > > make check & functional testing... > > ``` > ./src/mesos-execute --name="test" --env='{"key1":"value1"}' --command='sleep > 1000' --master=127.0.0.1:5050 > ``` > > Within the contents of `stdout` before applying this: > ``` > Overwriting environment variable 'key1', original: 'value1', new: 'value1' > ``` > > After applying this there is no mention of the actually duplicate but equally > valued variable anymore. Note, this is before applying > https://reviews.apache.org/r/57762. > > > Thanks, > > Till Toenshoff > >
