> On March 23, 2017, 12:46 a.m., Adam B wrote: > > src/slave/containerizer/mesos/launch.cpp > > Line 664 (original), 664 (patched) > > <https://reviews.apache.org/r/57763/diff/1/?file=1668097#file1668097line664> > > > > Rather than printing the original/new values, we could at least explain > > which environment is overriding (e.g. task environment overrides > > isolator/os::environment).
No source available at this point. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57763/#review169798 ----------------------------------------------------------- On March 20, 2017, 2:51 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57763/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 2:51 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Bannier, Jie > Yu, and Joseph Wu. > > > Bugs: MESOS-7264 > https://issues.apache.org/jira/browse/MESOS-7264 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/launch.cpp > 8658525b00e78bed9227d6d400eccccae2cf25dd > > > Diff: https://reviews.apache.org/r/57763/diff/2/ > > > Testing > ------- > > make check & functional testing... > > ``` > ./src/mesos-execute --name="test" --env='{"key1":"value1"}' --command='sleep > 1000' --master=127.0.0.1:5050 > ``` > > Within the contents of `stdout` before applying this: > ``` > Overwriting environment variable 'key1', original: 'value1', new: 'value1' > ``` > > After applying this there is no mention of the actually duplicate but equally > valued variable anymore. Note, this is before applying > https://reviews.apache.org/r/57762. > > > Thanks, > > Till Toenshoff > >
