> On March 21, 2017, 5:25 p.m., Gastón Kleiman wrote: > > src/tests/check_tests.cpp > > Lines 293-295 (patched) > > <https://reviews.apache.org/r/56213/diff/9/?file=1668396#file1668396line293> > > > > To be consistent with the other tests, this should be just one line: > > > > `checkInfo->mutable_command()->mutable_command()->set_value("exit > > $STATUS");`
The reason why it's inconsistent, is because `checkCommand` is used right after to set env vars. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review169466 ----------------------------------------------------------- On March 20, 2017, 5:13 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 5:13 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gastón Kleiman, and Vinod > Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > src/tests/mesos.hpp f39e243c2c11bc1c9c757049fda2122727d1fef9 > > > Diff: https://reviews.apache.org/r/56213/diff/9/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
