> On March 14, 2017, 6:24 p.m., Andrew Schwartzmeyer wrote: > > src/tests/check_tests.cpp > > Lines 74 (patched) > > <https://reviews.apache.org/r/56213/diff/6/?file=1663407#file1663407line74> > > > > As the resident PowerShell "expert" (heh!), I tested this (and the > > second one) and they do what you're expecting. > > > > Just a couple notes: > > > > You might be wanting to use `Test-Path "somepath"` instead, which > > returns a boolean for existence of that path, so you can do `if (Test-Path > > "somepath")` instead of the gunk around checking `$?`. Also, semicolons are > > unnecssary in PowerShell except to separate multiple commands on one line. > > If you want it to be _perfect_ we try to prefer the `Camel-Case` of cmdlet > > names, but it's whatever. > > Vinod Kone wrote: > Thanks Andrew for the reply. > > @Alex Do you want to update accordingly?
Sure. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56213/#review168922 ----------------------------------------------------------- On March 16, 2017, 4:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56213/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:46 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > src/tests/mesos.hpp f39e243c2c11bc1c9c757049fda2122727d1fef9 > > > Diff: https://reviews.apache.org/r/56213/diff/7/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
