> On March 23, 2017, 3:35 a.m., Anand Mazumdar wrote: > > src/slave/slave.cpp > > Lines 2777-2778 (patched) > > <https://reviews.apache.org/r/57743/diff/6/?file=1671458#file1671458line2779> > > > > hmm, copy/paste error for the comment? > > > > Can you modify it to say that we don't launch the executor as the > > framework is terminating?
Just removed this comment since the code is self-explanatory. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57743/#review169731 ----------------------------------------------------------- On March 23, 2017, 4:14 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57743/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 4:14 p.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch updates the agent code to generate executor > authentication tokens when executor authentication is > enabled. For now, the generated `Secret` objects must > be of `VALUE` type, and they're passed directly into the > executor environment. > > > Diffs > ----- > > src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb > src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b > > > Diff: https://reviews.apache.org/r/57743/diff/7/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
