> On March 23, 2017, 3:35 a.m., Anand Mazumdar wrote: > > src/slave/slave.cpp > > Lines 2655-2705 (patched) > > <https://reviews.apache.org/r/57743/diff/6/?file=1671458#file1671458line2657> > > > > hmm, there are two problems with this helper. > > > > - The severe one is that if the secret generation fails and we go ahead > > and remove the executor if the framework had no pending tasks. The > > assertion would fail > > https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L4943 since > > the state of the executor is still `REGISTERING`. > > - We also don't send a `ExitedExecutorMessage` to the master. This > > would mean that the master won't ever free up the executor resources since > > it would still think that the task is active. > > > > Can we instead delegate the cleanup to the `executorTerminated` > > function and just invoke it from here? > > Greg Mann wrote: > Implemented this using `executorTerminated`, but now not seeing status > updates, need to investigate.
This was a problem with my test, fixed now. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57743/#review169731 ----------------------------------------------------------- On March 23, 2017, 9:30 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57743/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 9:30 p.m.) > > > Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch updates the agent code to generate executor > authentication tokens when executor authentication is > enabled. For now, the generated `Secret` objects must > be of `VALUE` type, and they're passed directly into the > executor environment. > > > Diffs > ----- > > src/slave/slave.hpp e2de66cc5b899b8b9a9ea27cc30f19a9e8fc11fb > src/slave/slave.cpp a4f4a9ca80b726de8e07571fd6d93120947c278b > > > Diff: https://reviews.apache.org/r/57743/diff/9/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
