> On March 22, 2017, 12:17 p.m., Greg Mann wrote:
> > src/tests/scheduler_tests.cpp
> > Lines 688 (patched)
> > <https://reviews.apache.org/r/57807/diff/2/?file=1671198#file1671198line695>
> >
> >     Remove this to speed up the test.
> 
> Greg Mann wrote:
>     Removing this doesn't seem to have sped up the test, still need to figure 
> out why it's taking so long.

Since I'm waiting on receipt of both the TASK_RUNNING and TASK_FINISHED 
updates, I had to add update acknowledgements to allow the TASK_FINISHED to be 
sent immediately.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57807/#review169697
-----------------------------------------------------------


On March 23, 2017, 9:31 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57807/
> -----------------------------------------------------------
> 
> (Updated March 23, 2017, 9:31 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Benjamin Mahler, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-6999
>     https://issues.apache.org/jira/browse/MESOS-6999
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the test `SchedulerTest.TaskGroupRunning`
> to confirm that the agent-side code responsible for launching
> task groups works correctly. Previously, this test only
> verified that the `RunTaskGroupMessage` was sent to the agent.
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 65259b47ec1a2094b23ff448370d30122fd218ca 
> 
> 
> Diff: https://reviews.apache.org/r/57807/diff/5/
> 
> 
> Testing
> -------
> 
> `make check` was done to test that all existing tests succeed when executor 
> authentication is enabled by default in the test cluster code. The 
> ExecutorHttpApiTests are the only tests in which it has been disabled.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to