----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57807/#review169979 -----------------------------------------------------------
src/tests/scheduler_tests.cpp Lines 543 (patched) <https://reviews.apache.org/r/57807/#comment242703> s/agent's/agent ? src/tests/scheduler_tests.cpp Lines 575 (patched) <https://reviews.apache.org/r/57807/#comment242702> // Ignore subsequent offers. src/tests/scheduler_tests.cpp Lines 673 (patched) <https://reviews.apache.org/r/57807/#comment242707> s/EXPECT_EQ/ASSERT_EQ? src/tests/scheduler_tests.cpp Lines 676 (patched) <https://reviews.apache.org/r/57807/#comment242708> s/EXPECT_EQ/ASSERT_EQ? src/tests/scheduler_tests.cpp Lines 680 (patched) <https://reviews.apache.org/r/57807/#comment242704> Can you add a comment here for posterity similar to what we have in the default executor tests: ```cpp // When running a task, TASK_RUNNING updates for the tasks in a // task group can be received in any order. ``` src/tests/scheduler_tests.cpp Lines 684 (patched) <https://reviews.apache.org/r/57807/#comment242709> s/EXPECT_EQ/ASSERT_EQ? Do you want to continue the test if even the initial status updates don't match? src/tests/scheduler_tests.cpp Lines 685 (patched) <https://reviews.apache.org/r/57807/#comment242705> ```cpp // Acknowledge the TASK_RUNNING updates to receive the next updates. ``` src/tests/scheduler_tests.cpp Lines 718 (patched) <https://reviews.apache.org/r/57807/#comment242706> hmm, why not check of the task state in the update is `TASK_FINISHED`? - Anand Mazumdar On March 23, 2017, 11:17 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57807/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 11:17 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, Benjamin Mahler, > and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch updates the test `SchedulerTest.TaskGroupRunning` > to confirm that the agent-side code responsible for launching > task groups works correctly. Previously, this test only > verified that the `RunTaskGroupMessage` was sent to the agent. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp 65259b47ec1a2094b23ff448370d30122fd218ca > > > Diff: https://reviews.apache.org/r/57807/diff/6/ > > > Testing > ------- > > `make check` was done to test that all existing tests succeed when executor > authentication is enabled by default in the test cluster code. The > ExecutorHttpApiTests are the only tests in which it has been disabled. > > > Thanks, > > Greg Mann > >
