----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57646/#review169959 -----------------------------------------------------------
src/checks/health_checker.cpp Lines 362-364 (original), 366-367 (patched) <https://reviews.apache.org/r/57646/#comment242682> I'm not sure this formatting is superior to what was before. src/checks/health_checker.cpp Lines 560 (patched) <https://reviews.apache.org/r/57646/#comment242681> Is this necessary? src/checks/health_checker.cpp Line 617 (original), 618 (patched) <https://reviews.apache.org/r/57646/#comment242683> Please either trailing or leading undescore. src/checks/health_checker.cpp Lines 646-651 (original), 649-654 (patched) <https://reviews.apache.org/r/57646/#comment242684> It would be great to keep argument list sorted in the same way across all continuations, e.g. `promise` beign the first. - Alexander Rukletsov On March 23, 2017, 8:07 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57646/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 8:07 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Made COMMAND health checks resilient to agent failovers. > > > Diffs > ----- > > src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 > src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 > > > Diff: https://reviews.apache.org/r/57646/diff/5/ > > > Testing > ------- > > `make check` in Linux > > > Thanks, > > Gastón Kleiman > >
