> On March 24, 2017, 4:23 p.m., Anand Mazumdar wrote: > > src/tests/mock_slave.hpp > > Lines 118 (patched) > > <https://reviews.apache.org/r/57882/diff/2/?file=1673068#file1673068line118> > > > > ` > > virtual void initialize() override; > > ` ?
The compiler complains about inconsistent use of override if we add this, so I'm leaving it out for now. We could do a batch update of all the mock agent methods later if we want. There is already a ticket for doing a sweep of the entire codebase to add `override`: MESOS-4871 - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57882/#review170023 ----------------------------------------------------------- On March 24, 2017, 9:24 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57882/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 9:24 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds an overload of `Slave::initialize` to the > mock slave for the purpose of injecting a secret generator. > > > Diffs > ----- > > src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 > src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf > > > Diff: https://reviews.apache.org/r/57882/diff/3/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
