----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57882/#review170092 -----------------------------------------------------------
Fix it, then Ship it! src/tests/mock_slave.hpp Lines 204 (patched) <https://reviews.apache.org/r/57882/#comment242880> New line before? Also how about: ```cpp // Set to the base class `secretGenerator` in `initialize()`. After `initialize()` has executed, // this will be `None()`. ``` - Anand Mazumdar On March 24, 2017, 9:24 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57882/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 9:24 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds an overload of `Slave::initialize` to the > mock slave for the purpose of injecting a secret generator. > > > Diffs > ----- > > src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 > src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf > > > Diff: https://reviews.apache.org/r/57882/diff/3/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
