> On March 24, 2017, 6:24 p.m., Anand Mazumdar wrote: > > src/tests/slave_tests.cpp > > Lines 5277-5301 (patched) > > <https://reviews.apache.org/r/57883/diff/2/?file=1673064#file1673064line5277> > > > > Kill this? You are not expecting more status updates for the same task.
These acks, and the similar ones below, are necessary to allow the agent to call `removeFramework`. I'll add a comment to make that clear. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57883/#review170030 ----------------------------------------------------------- On March 24, 2017, 9:32 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57883/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 9:32 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds new tests, > `SlaveTest.RunTaskGroupFailedSecretGeneration` and > `SlaveTest.RunTaskGroupInvalidExecutorSecret`, to > verify the agent's behavior when generation of the > executor secret fails. > > > Diffs > ----- > > src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a > > > Diff: https://reviews.apache.org/r/57883/diff/3/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh > --gtest_filter="*SlaveTest.RunTaskGroupFailedSecretGeneration*:SlaveTest.RunTaskGroupInvalidExecutorSecret*" > --gtest_repeat=-1 --gtest_break_on_failure` was used to verify that the new > tests are not flaky. > > > Thanks, > > Greg Mann > >
