----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57883/#review170093 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 5138 (patched) <https://reviews.apache.org/r/57883/#comment242881> Newline before. s/perform/perform the src/tests/slave_tests.cpp Lines 5338 (patched) <https://reviews.apache.org/r/57883/#comment242884> Ditto as above. src/tests/slave_tests.cpp Lines 5405-5406 (patched) <https://reviews.apache.org/r/57883/#comment242885> How about: // The tasks will fail to launch because the executor secret is invalid (VALUE type secrets must not have the `reference` member set). - Anand Mazumdar On March 25, 2017, 5:45 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57883/ > ----------------------------------------------------------- > > (Updated March 25, 2017, 5:45 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch adds new tests, > `SlaveTest.RunTaskGroupFailedSecretGeneration` and > `SlaveTest.RunTaskGroupInvalidExecutorSecret`, to > verify the agent's behavior when generation of the > executor secret fails. > > > Diffs > ----- > > src/tests/slave_tests.cpp c31c670b667240c4876d415aa5cf90cb34273e8a > > > Diff: https://reviews.apache.org/r/57883/diff/6/ > > > Testing > ------- > > `make check` > `bin/mesos-tests.sh > --gtest_filter="*SlaveTest.RunTaskGroupFailedSecretGeneration*:SlaveTest.RunTaskGroupInvalidExecutorSecret*" > --gtest_repeat=-1 --gtest_break_on_failure` was used to verify that the new > tests are not flaky. > > > Thanks, > > Greg Mann > >
