----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56193/#review170223 -----------------------------------------------------------
src/docker/docker.cpp Lines 524 (patched) <https://reviews.apache.org/r/56193/#comment243006> Can you test if docker support arbitratry double here like 1.000001 (more than 3 digits after decimal point)? Also, looks like 0.000 means unlimited. I am wondering if we should set a MIN_CPUS here just to be consistent with the cpu share based semantics. - Jie Yu On Feb. 1, 2017, 10:31 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56193/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 10:31 p.m.) > > > Review request for mesos, Jie Yu and Kevin Klues. > > > Bugs: MESOS-7006 > https://issues.apache.org/jira/browse/MESOS-7006 > > > Repository: mesos > > > Description > ------- > > Docker 1.13 introduces new flag `--cpus` for limiting cpu usage > of a container. We can use this flag to avoid cpu share calculation > and just pass cpus resources to Docker. > > > Diffs > ----- > > src/docker/docker.cpp b63b060ba1c1d39dc1702368cf667831edbd39bd > > > Diff: https://reviews.apache.org/r/56193/diff/1/ > > > Testing > ------- > > > Thanks, > > Tomasz Janiszewski > >
