----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review170717 -----------------------------------------------------------
Bad review! Reviews applied: [57190, 57166, 56805, 57165, 57164] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On March 31, 2017, 12:54 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57190/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 12:54 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, Michael Park, and Neil > Conway. > > > Bugs: MESOS-7047 > https://issues.apache.org/jira/browse/MESOS-7047 > > > Repository: mesos > > > Description > ------- > > This commit adjusts the way persistent volumes are stored on the > agent. Instead of interpreting the role of the volume as a literal > path, we replace `/` with ` ` when creating the path. This prevents > that subdirectories are created for volumes with hierarchical roles. > Directly interpreting the role as a path is undesirable as it can lead > to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id` > would be visible as `id` in a volume with role `a/b/c` and id `d`). > > > Diffs > ----- > > src/slave/paths.cpp ef22ee167f16030f02d28c8e6bab6c2ca4812d8f > src/tests/role_tests.cpp 0433c0599eac5f4648bc0dfe3a0fa8d5f7a836ca > > > Diff: https://reviews.apache.org/r/57190/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
