> On March 30, 2017, 8:36 a.m., Benjamin Bannier wrote: > > The changes here look good to me, but running > > > > % CHECKS='-*,performance-unnecessary-copy-initialization' > > ./support/mesos-tidy.sh > > > > still emits a lot of unneeded copy warnings. Could you have a look what > > other candidates for a fix are there? Ideally we'd either be able to fix > > all instances and add this to the default check list.
Yeah, there are a lot of other places to fix -- I wanted to do them piecemeal, though (e.g., the copy semantics around `Future<T>` can be subtle). The places I fixed in this patch all seemed quite straightforward, so I'd prefer to leave the other places for a separate change. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/#review170548 ----------------------------------------------------------- On March 30, 2017, 1:15 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58040/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 1:15 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Spotted using the "performance-unnecessary-copy-initialization" > clang-tidy check. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > c1650dc978dddf14cf1e22a33752b58b06914ff4 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade > src/oci/spec.cpp 06fceb4f0441431d756eb45c8aaf9730ef9e248a > src/tests/default_executor_tests.cpp > 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f > > > Diff: https://reviews.apache.org/r/58040/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
