----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58040/#review170913 -----------------------------------------------------------
Ship it! Let's get these in as they are strictly improvements. To make such changes cheaper in the future I am strongly in favor of making a sweep across the code base, and default-enable a new test catching future regressions in `support/mesos-tidy.sh`'s. - Benjamin Bannier On March 30, 2017, 3:15 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58040/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 3:15 a.m.) > > > Review request for mesos and Benjamin Bannier. > > > Repository: mesos > > > Description > ------- > > Spotted using the "performance-unnecessary-copy-initialization" > clang-tidy check. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > c1650dc978dddf14cf1e22a33752b58b06914ff4 > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/master.cpp ab071f56a66ae66c97a185b2377a9cfe9a5c1ade > src/oci/spec.cpp 06fceb4f0441431d756eb45c8aaf9730ef9e248a > src/tests/default_executor_tests.cpp > 6dadd8937eb6809bcb0aca55fab1cb7f17c3262f > > > Diff: https://reviews.apache.org/r/58040/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
