> On March 17, 2017, 9:32 p.m., Greg Mann wrote: > > src/master/master.hpp > > Lines 684-686 (patched) > > <https://reviews.apache.org/r/57535/diff/3/?file=1665114#file1665114line684> > > > > Could you leave a TODO here to update this function to use `Principal` > > when MESOS-7202 is resolved? > > Jiang Yan Xu wrote: > Will MESOS-7202 cover the master <-> agent protocol and the > `authenticated`?
Hmm perhaps not, since the master <-> agent communication will still be authenticated using the PID-based authenticator interface. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57535/#review169325 ----------------------------------------------------------- On March 28, 2017, 8:40 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57535/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 8:40 a.m.) > > > Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, Benjamin > Mahler, Greg Mann, and Vinod Kone. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > Applied RegisterAgent ACL to the master. > > > Diffs > ----- > > src/master/master.hpp d92c8adef79d997f255cf26ebd10ab0e87da8413 > src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f > src/tests/master_authorization_tests.cpp > 1a0285a3f345ef21a8256d4123d8bb684f538da4 > > > Diff: https://reviews.apache.org/r/57535/diff/6/ > > > Testing > ------- > > make check. > > The tests added here cover some basic scenarios, I have more tests but will > add them when MESOS-7244 is fixed. > > > Thanks, > > Jiang Yan Xu > >
