----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58252/#review171317 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp Line 1091 (original), 1091 (patched) <https://reviews.apache.org/r/58252/#comment244219> Not yours (it might even be mine), but if we already checked in the previous line `!request.has_subject()`, the only posibility is that it does have a subject and `request.has_subject()` is unnecesary. I would delete it. - Alexander Rojas On April 7, 2017, 5:26 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58252/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 5:26 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod > Kone. > > > Bugs: MESOS-7014 > https://issues.apache.org/jira/browse/MESOS-7014 > > > Repository: mesos > > > Description > ------- > > This patch updates checks in the local authorizer to allow subjects > which specify `claims` instead of a `value`. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > e241edf4afa48d35dbbbb94d72e8e8690f5bedfc > > > Diff: https://reviews.apache.org/r/58252/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
