----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58252/#review171525 -----------------------------------------------------------
LGTM. Just get rid of the unnecessary parentheses. src/authorizer/local/authorizer.cpp Line 1091 (original), 1091 (patched) <https://reviews.apache.org/r/58252/#comment244475> No reason for the extra parentheses around this pair anymore either. Why not: ``` CHECK(!request.has_subject() || request.subject().has_value() || request.subject().has_claims()); ``` - Adam B On April 7, 2017, 4:15 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58252/ > ----------------------------------------------------------- > > (Updated April 7, 2017, 4:15 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Till Toenshoff, and Vinod > Kone. > > > Bugs: MESOS-7014 > https://issues.apache.org/jira/browse/MESOS-7014 > > > Repository: mesos > > > Description > ------- > > This patch updates checks in the local authorizer to allow subjects > which specify `claims` instead of a `value`. > > > Diffs > ----- > > src/authorizer/local/authorizer.cpp > e241edf4afa48d35dbbbb94d72e8e8690f5bedfc > > > Diff: https://reviews.apache.org/r/58252/diff/2/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
