----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58317/#review171490 -----------------------------------------------------------
Patch looks great! Reviews applied: [58317] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 10, 2017, 6:16 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58317/ > ----------------------------------------------------------- > > (Updated April 10, 2017, 6:16 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Bugs: MESOS-7346 > https://issues.apache.org/jira/browse/MESOS-7346 > > > Repository: mesos > > > Description > ------- > > When launching a task with a very long name `mkdir` will fail and crash the > agent, making it quick and easy to remotely crash any agent(s). This changes > makes sure that we never exceed the default file name limit of most of the > file systems out there. If the limit is exceed a `TASK_ERROR` is instead sent > back to the client. > > > Diffs > ----- > > src/common/validation.cpp 544d3a0bf > > > Diff: https://reviews.apache.org/r/58317/diff/1/ > > > Testing > ------- > > Built Mesos, ran 1 master and 1 agent locally, and launched a task with a > name > 255 characters through our own custom framework. > > ``` > I0410 14:04:15.761109 28528 master.cpp:6323] Sending status update TASK_ERROR > for task > tesijetjijwtjwitjweitjweitjwitjweitjtijeiojwetoijetweoijwilgjwkdgsjskd.nlskdgnldksnglsdkgndslgjdslgjsdlgjldskgjsdlkgjslkgjslkdgjsdlkgjskldgjweiojgoeiwgjweoigjewoitjweoitjewiotjewitjweitjewitjwewejiowejiewtiwethewothweuothewouthuthwouthwuothgwuoghwouhweouthewhtiewtwetwhtohwethwetwehtwehtwjethwejlthwejlthwejhtwejthwejkthwejkthwejkthwejthwkthwekthwtkjwthkwjehtjkwehtkjwehtkjwehtkjwehtkwejhtewjkthewkjthewjkthwekjthwekjthwekjthwekjthwekjhtwekhtewkapplication227741021670-4A491BFF-F50D-4F17-B304-AD23423F15EE > of framework 9e8d9439-7ed2-4968-a8cb-f46273c2d9af-0000 'ID must not be > greater than 255 characters' > ``` > > > Thanks, > > Aaron Wood > >
