-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58317/
-----------------------------------------------------------
(Updated April 10, 2017, 10:37 p.m.)
Review request for mesos, Jie Yu and James Peach.
Changes
-------
Use `NAME_MAX` instead of a hardcoded number.
Bugs: MESOS-7346
https://issues.apache.org/jira/browse/MESOS-7346
Repository: mesos
Description
-------
When launching a task with a very long name `mkdir` will fail and crash the
agent, making it quick and easy to remotely crash any agent(s). This changes
makes sure that we never exceed the default file name limit of most of the file
systems out there. If the limit is exceed a `TASK_ERROR` is instead sent back
to the client.
Diffs (updated)
-----
src/common/validation.cpp 544d3a0bf
Diff: https://reviews.apache.org/r/58317/diff/2/
Changes: https://reviews.apache.org/r/58317/diff/1-2/
Testing
-------
Built Mesos, ran 1 master and 1 agent locally, and launched a task with a name
> 255 characters through our own custom framework.
```
I0410 14:04:15.761109 28528 master.cpp:6323] Sending status update TASK_ERROR
for task
tesijetjijwtjwitjweitjweitjwitjweitjtijeiojwetoijetweoijwilgjwkdgsjskd.nlskdgnldksnglsdkgndslgjdslgjsdlgjldskgjsdlkgjslkgjslkdgjsdlkgjskldgjweiojgoeiwgjweoigjewoitjweoitjewiotjewitjweitjewitjwewejiowejiewtiwethewothweuothewouthuthwouthwuothgwuoghwouhweouthewhtiewtwetwhtohwethwetwehtwehtwjethwejlthwejlthwejhtwejthwejkthwejkthwejkthwejthwkthwekthwtkjwthkwjehtjkwehtkjwehtkjwehtkjwehtkwejhtewjkthewkjthewjkthwekjthwekjthwekjthwekjthwekjhtwekhtewkapplication227741021670-4A491BFF-F50D-4F17-B304-AD23423F15EE
of framework 9e8d9439-7ed2-4968-a8cb-f46273c2d9af-0000 'ID must not be greater
than 255 characters'
```
Thanks,
Aaron Wood
