> On April 12, 2017, 9:53 a.m., Alexander Rukletsov wrote: > > src/checks/health_checker.hpp > > Lines 234 (patched) > > <https://reviews.apache.org/r/58368/diff/1/?file=1689475#file1689475line234> > > > > Is pass-by-value intended here?
Yea I did intend to store a copy of the authorization header here in the `HealthCheckerProcess`. I guess the other option is to store a reference and rely on the copy stored within the default executor? I'd prefer to keep the process's context encapsulated here to avoid possible thread safety issues, and we do pass the `authorizationHeader` parameter by reference when creating the process via `create()`. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58368/#review171696 ----------------------------------------------------------- On April 12, 2017, 9:20 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58368/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 9:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Gastón > Kleiman, and Vinod Kone. > > > Bugs: MESOS-7377 > https://issues.apache.org/jira/browse/MESOS-7377 > > > Repository: mesos > > > Description > ------- > > This patch updates the `HealthChecker` to permit initialization > with an authorization header, which it will provide to the agent > operator API for authentication when present. > > > Diffs > ----- > > src/checks/health_checker.hpp e17f12f75d388443f6592455177f5bdae31b7c0f > src/checks/health_checker.cpp 769278c40b5e505dc49a49a23d8c0dd97f201a53 > > > Diff: https://reviews.apache.org/r/58368/diff/1/ > > > Testing > ------- > > Testing details can be found at the end of this chain. > > > Thanks, > > Greg Mann > >
