----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58512/ -----------------------------------------------------------
Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-7400 https://issues.apache.org/jira/browse/MESOS-7400 Repository: mesos Description ------- If the callback `on_headers_complete()` fails, the decoder's writer object is `None()`. So, when the callback `on_message_complete()` is called, we should not crash in that case. Note that the `CHECK(decoder->writer)` is valid for the callback `on_body()` is valid since this callback is called only on a success in `on_headers_complete()` callback. Diffs ----- 3rdparty/libprocess/src/decoder.hpp 4c779d42548958e610142438a57529ccb4478053 Diff: https://reviews.apache.org/r/58512/diff/1/ Testing ------- All tests passed. Thanks, Anindya Sinha