----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172416 -----------------------------------------------------------
src/master/validation.cpp Lines 241 (patched) <https://reviews.apache.org/r/58305/#comment245517> Typo. src/master/validation.cpp Lines 258 (patched) <https://reviews.apache.org/r/58305/#comment245518> Can we phrase this like: "Framework has duplicate FrameworkID: '" src/master/validation.cpp Lines 259 (patched) <https://reviews.apache.org/r/58305/#comment245525> Whitespace-wise, I think this should be: ``` return Error("abc" + "xyz"); ``` Here and below. src/master/validation.cpp Lines 283 (patched) <https://reviews.apache.org/r/58305/#comment245519> "Executor has duplicate ExecutorID: '" src/master/validation.cpp Lines 311 (patched) <https://reviews.apache.org/r/58305/#comment245515> Seems unintended. src/master/validation.cpp Lines 313 (patched) <https://reviews.apache.org/r/58305/#comment245524> "Task has an invalid ExecutorID: " (for consistency) src/tests/master_validation_tests.cpp Lines 3738 (patched) <https://reviews.apache.org/r/58305/#comment245520> I'd move `detector` down below the `SlaveRegisteredMessage` expectation -- IMO makes sense to cluster the arguments to `StartSlave` together. src/tests/master_validation_tests.cpp Lines 3763 (patched) <https://reviews.apache.org/r/58305/#comment245521> `Task*` src/tests/master_validation_tests.cpp Lines 3776 (patched) <https://reviews.apache.org/r/58305/#comment245522> `string` src/tests/master_validation_tests.cpp Lines 3778 (patched) <https://reviews.apache.org/r/58305/#comment245523> `process::post(slave.get()->pid, master->get()->pid, message);` would be simpler. - Neil Conway On April 19, 2017, 10:05 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58305/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 10:05 p.m.) > > > Review request for mesos, Mesos Reviewbot and Neil Conway. > > > Bugs: MESOS-7372 > https://issues.apache.org/jira/browse/MESOS-7372 > > > Repository: mesos > > > Description > ------- > > The ReRegisterSlaveMessage message sends a number of fields which have > internal consistency requirements. Add some simple validation checks > to ensure that we have a minimally consistent re-registration request > before proceeding. > > > Diffs > ----- > > src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 > src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e > src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa > src/tests/master_validation_tests.cpp > 555380870ae115004312cfbe9f145faa92049030 > > > Diff: https://reviews.apache.org/r/58305/diff/7/ > > > Testing > ------- > > Make check (Fedora 25). Internal fuzzing. > > > Thanks, > > James Peach > >
