----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58305/#review172419 -----------------------------------------------------------
src/master/validation.cpp Lines 257 (patched) <https://reviews.apache.org/r/58305/#comment245527> Per suggestion below, can we use ``` if (frameworkIDs.contains(...)) { return Error("..."); } frameworkIDs.insert(...); ``` for now? - Neil Conway On April 19, 2017, 10:05 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58305/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 10:05 p.m.) > > > Review request for mesos, Mesos Reviewbot and Neil Conway. > > > Bugs: MESOS-7372 > https://issues.apache.org/jira/browse/MESOS-7372 > > > Repository: mesos > > > Description > ------- > > The ReRegisterSlaveMessage message sends a number of fields which have > internal consistency requirements. Add some simple validation checks > to ensure that we have a minimally consistent re-registration request > before proceeding. > > > Diffs > ----- > > src/master/master.cpp 52de2f91bdacf46f913c27382ad50b4f278ad297 > src/master/validation.hpp d96287de73ddb30ae2ed841c1b910b0ac6cfa74e > src/master/validation.cpp 3f70875484bbd856ac79a7d6070ac313d69782fa > src/tests/master_validation_tests.cpp > 555380870ae115004312cfbe9f145faa92049030 > > > Diff: https://reviews.apache.org/r/58305/diff/7/ > > > Testing > ------- > > Make check (Fedora 25). Internal fuzzing. > > > Thanks, > > James Peach > >