----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58508/#review172459 -----------------------------------------------------------
src/common/resources.cpp Lines 909 (patched) <https://reviews.apache.org/r/58508/#comment245582> This would incorrectly declare `foo/bar` to be inheritable by `foo/ba`, right? I think we need to `tokenize` and check for prefix of the result? - Michael Park On April 18, 2017, 8:43 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58508/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 8:43 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-7149 > https://issues.apache.org/jira/browse/MESOS-7149 > > > Repository: mesos > > > Description > ------- > > A reservation is inheritable by 'role' iff: > - it is reserved to ancestor of 'role' in hierarchy, OR > - it is reserved to 'role' itself. > > This is a helper function for reservation delegate, where reserved > resources can be 'delegated' downwards in the hierarchy. > > > Diffs > ----- > > include/mesos/resources.hpp 74583e3c784f22b45cce81f07c5a69b339e1684d > src/common/resources.cpp 77bac0c4390da905016a942991b14a79877f8455 > src/tests/resources_tests.cpp 4cf320d802a749f1419ac5b9f63b6c73b0c974be > > > Diff: https://reviews.apache.org/r/58508/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
