----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/#review172540 -----------------------------------------------------------
This also needs documentation added to the `docs/monitoring.md`. src/master/allocator/sorter/drf/metrics.hpp Lines 59 (patched) <https://reviews.apache.org/r/53841/#comment245643> Why is this necessary? Is there a reason that publishing the dominant resources and shares for quotas doesn't make sense? src/master/allocator/sorter/drf/metrics.cpp Lines 50 (patched) <https://reviews.apache.org/r/53841/#comment245647> Use `path::join()` here. src/master/allocator/sorter/drf/metrics.cpp Lines 64 (patched) <https://reviews.apache.org/r/53841/#comment245644> Can you do the initialization in the constructor? - James Peach On April 19, 2017, 8:52 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53841/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 8:52 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-6579 > https://issues.apache.org/jira/browse/MESOS-6579 > > > Repository: mesos > > > Description > ------- > > Following metrics have been added: > a) allocator/mesos/roles/sort_runs: Number of role level sorts. > b) allocator/mesos/roles/sort_run: Latency in role level sorts. > c) allocator/mesos/quotas/sort_runs: Number of quota level sorts. > d) allocator/mesos/quotas/sort_run: Latency in quota level sorts. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 646f66e67d9c6b8c61fc6e6558a1db976a44c126 > src/master/allocator/sorter/drf/metrics.hpp > 61568cb520826ab59d675824b212e0d3deb63764 > src/master/allocator/sorter/drf/metrics.cpp > 15aab32db5ca1a7a14080e9bbb7c65283be3ec20 > src/master/allocator/sorter/drf/sorter.hpp > 76329220e1115c1de7810fb69b943c78c078be59 > src/master/allocator/sorter/drf/sorter.cpp > ed54680cecb637931fc344fbcf8fd3b14cc24295 > src/tests/hierarchical_allocator_tests.cpp > cdf1f15b7802439b28405ca8f6634ce83e886630 > > > Diff: https://reviews.apache.org/r/53841/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
