> On April 20, 2017, 9:15 p.m., James Peach wrote: > > src/master/allocator/sorter/drf/metrics.hpp > > Lines 59 (patched) > > <https://reviews.apache.org/r/53841/diff/3/?file=1658621#file1658621line59> > > > > Why is this necessary? Is there a reason that publishing the dominant > > resources and shares for quotas doesn't make sense?
The reason publishing the dominant resources and shares for quotas is disabled because that is what was originally. The flag `includeClientMetrics` is most useful for framework sorters since we keep it disabled because of the possibility of high number of framework sorters (https://reviews.apache.org/r/53842/). However, I think it makes sense to enable this for quotas though. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/#review172540 ----------------------------------------------------------- On May 16, 2017, 6:24 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53841/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 6:24 a.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-6579 > https://issues.apache.org/jira/browse/MESOS-6579 > > > Repository: mesos > > > Description > ------- > > Following metrics have been added: > a) allocator/mesos/roles/sort_runs: Number of role level sorts. > b) allocator/mesos/roles/sort_run: Latency in role level sorts. > c) allocator/mesos/quotas/sort_runs: Number of quota level sorts. > d) allocator/mesos/quotas/sort_run: Latency in quota level sorts. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 123f97cf495bff0f822838e09df0d88818f04da6 > src/master/allocator/sorter/drf/metrics.hpp > 61568cb520826ab59d675824b212e0d3deb63764 > src/master/allocator/sorter/drf/metrics.cpp > ff63fbac5bbcf54e1ae39c3b650c0dafe7ea46d4 > src/master/allocator/sorter/drf/sorter.hpp > fee58d6d1f08163e2a06a4a20c891fe535c3dcff > src/master/allocator/sorter/drf/sorter.cpp > 26b77f578f3235a8792c72d4575d607cdb2c7de7 > src/tests/hierarchical_allocator_tests.cpp > 08180b9975869de328f0c095dd3cddf0c84fbecf > > > Diff: https://reviews.apache.org/r/53841/diff/4/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
