----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review172681 -----------------------------------------------------------
LGTM! Can we have a test? It doesn't have to be a standalone test if we already have a test that just launches tasks from two frameworks, then we can just add it to the test? If not seems like that's proper test to have in general? src/master/master.cpp Lines 8896 (patched) <https://reviews.apache.org/r/57963/#comment245735> s/same/the same/? src/slave/slave.cpp Lines 6703 (patched) <https://reviews.apache.org/r/57963/#comment245733> The `slave` in `slaveUsed` seems redundant here (my example was on the master), here we have only one agent. s/slaveUsed/used/? src/slave/slave.cpp Lines 6747 (patched) <https://reviews.apache.org/r/57963/#comment245734> Ditto. - Jiang Yan Xu On March 27, 2017, 3:27 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57963/ > ----------------------------------------------------------- > > (Updated March 27, 2017, 3:27 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-7186 > https://issues.apache.org/jira/browse/MESOS-7186 > > > Repository: mesos > > > Description > ------- > > The following metrics take the shared counts of shared resources into > account in determination of the actual amount of used resources: > a) `master/<resource-name>_used` > b) `master/<resource-name>_revocable_used` > c) `slave/<resource-name>_used` > d) `slave/<resource-name>_revocable_used` > > > Diffs > ----- > > src/master/master.cpp 43e9d26167c1f405329ea05224c22e7b8c65315f > src/slave/slave.cpp c8479d7e8eb915284f0ea8cf75f47acd679dee7e > > > Diff: https://reviews.apache.org/r/57963/diff/2/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
