----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57963/#review173028 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 8950 (patched) <https://reviews.apache.org/r/57963/#comment246114> s/same/the same/ I forgot to say "all ocurrences". src/slave/slave.cpp Line 6743 (original), 6743 (patched) <https://reviews.apache.org/r/57963/#comment246510> Perhaps I am pedantic but I think s/used/Resources arithmetic/ here is more clear. When I read "We use `used`" my immediate reaction was "instead of what?" because `used` is the only variable here. The comment is basically to remind the reader of the "magic" of Resources::+= so perhaps just directly say it? We could use the same wording for the `slaveUsed` case above so all of these comments are consistent (which was my original suggestion). - Jiang Yan Xu On April 22, 2017, 10 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57963/ > ----------------------------------------------------------- > > (Updated April 22, 2017, 10 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-7186 > https://issues.apache.org/jira/browse/MESOS-7186 > > > Repository: mesos > > > Description > ------- > > The following metrics take the shared counts of shared resources into > account in determination of the actual amount of used resources: > a) `master/<resource-name>_used` > b) `master/<resource-name>_revocable_used` > c) `slave/<resource-name>_used` > d) `slave/<resource-name>_revocable_used` > > > Diffs > ----- > > src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 > src/slave/slave.cpp 4ff522e75bc8de34fe2e7720bdd8ce3d32cbf803 > > > Diff: https://reviews.apache.org/r/57963/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
