----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/#review172945 -----------------------------------------------------------
I would also like to see some documentation of this metric in `docs/monitoring.md`. src/master/allocator/mesos/hierarchical.cpp Line 1427 (original), 1428 (patched) <https://reviews.apache.org/r/53840/#comment245939> You also need to stop the latency metric here, otherwise you will capture multiple allocator dispatches. src/master/allocator/mesos/metrics.hpp Line 69 (original), 69 (patched) <https://reviews.apache.org/r/53840/#comment245940> I think we should fix this comment. This measures the time spent in the allocation algorithm. src/master/allocator/mesos/metrics.hpp Lines 73 (patched) <https://reviews.apache.org/r/53840/#comment245941> Since this metric is measuring the latency from when the allocation was dispatched to when it executed, how about calling it `allocation_run_latency`? I find "interval" misleading since it is not the interval between runs. - James Peach On April 21, 2017, 5:53 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53840/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 5:53 p.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-6579 > https://issues.apache.org/jira/browse/MESOS-6579 > > > Repository: mesos > > > Description > ------- > > Added a metric 'allocator/mesos/allocation_run_interval_ms' which > tracks the latency between scheduling an allocation to an actual > allocation run. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 051f749dd5921a322ca930a042c31814616d38f9 > src/master/allocator/mesos/metrics.hpp > ce486eb079dc44bf0bbfad8668426c7ae87c97b3 > src/master/allocator/mesos/metrics.cpp > ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 > src/tests/hierarchical_allocator_tests.cpp > 33e7b455f8664858eb4f03727b076a10c80cd6e0 > > > Diff: https://reviews.apache.org/r/53840/diff/4/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
