> On April 25, 2017, 4:41 p.m., James Peach wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1427 (original), 1428 (patched) > > <https://reviews.apache.org/r/53840/diff/4/?file=1697513#file1697513line1428> > > > > You also need to stop the latency metric here, otherwise you will > > capture multiple allocator dispatches.
As Yan mentioned, I stop the `allocation_run_latency` as the first thing done in this function. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/#review172945 ----------------------------------------------------------- On May 16, 2017, 6:23 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53840/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 6:23 a.m.) > > > Review request for mesos, James Peach and Jiang Yan Xu. > > > Bugs: MESOS-6579 > https://issues.apache.org/jira/browse/MESOS-6579 > > > Repository: mesos > > > Description > ------- > > Added a metric 'allocator/mesos/allocation_run_interval_ms' which > tracks the latency between scheduling an allocation to an actual > allocation run. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > b75ed9a20a9a42f958cebbacd91e5e15b0d21394 > src/master/allocator/mesos/metrics.hpp > ce486eb079dc44bf0bbfad8668426c7ae87c97b3 > src/master/allocator/mesos/metrics.cpp > ec987fe0ce8605bf9e7c0ccbe3ac384deaf53be1 > src/tests/hierarchical_allocator_tests.cpp > 08180b9975869de328f0c095dd3cddf0c84fbecf > > > Diff: https://reviews.apache.org/r/53840/diff/5/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
