----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58709/#review173138 -----------------------------------------------------------
Fix it, then Ship it! Looks good, would be nice to pull out a MINIMUM_AGENT_VERSION constant in master/constants.hpp. src/master/master.cpp Lines 5404 (patched) <https://reviews.apache.org/r/58709/#comment246222> Since this is in two places I'm just a little worried about it finding it's way into more places and/or getting inconsistent. Could we pull out a MINIMUM_AGENT_VERSION into master/constants.hpp? src/master/master.cpp Lines 5408-5409 (patched) <https://reviews.apache.org/r/58709/#comment246223> Could we get the open and close quotes on the same line? Ditto below - Benjamin Mahler On April 25, 2017, 3:13 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58709/ > ----------------------------------------------------------- > > (Updated April 25, 2017, 3:13 p.m.) > > > Review request for mesos, Benjamin Mahler and Kapil Arya. > > > Bugs: MESOS-6976 > https://issues.apache.org/jira/browse/MESOS-6976 > > > Repository: mesos > > > Description > ------- > > Officially, Mesos 1.0.0 (and newer) masters do not support pre-1.0.0 > Mesos agents. However, we previously allowed old agents to register, > which resulted in several master crashes. As a short-term solution, we > fixed those crashes by adding backward compatibility mechanisms into the > master, but that backward compatibility code has made the master logic > more complicated and difficult to understand. > > This commit changes the master to ignore registration attempts by Mesos > agents that precede Mesos 1.0.0. Now that this safety check is in place, > master logic can safely assume that all agents are running at least > Mesos 1.0.0, which will allow several simplifications to be made. > > > Diffs > ----- > > src/master/master.cpp d1cdc35a066e190ef8e0bd788e07e63b92f7fce7 > src/tests/master_tests.cpp d1828eb42e0aedc9330c3786bbd9bb63aa42a64e > > > Diff: https://reviews.apache.org/r/58709/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
