----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58709/#review173601 -----------------------------------------------------------
Patch looks great! Reviews applied: [58897, 58707, 58708, 58709] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 1, 2017, 11:45 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58709/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 11:45 p.m.) > > > Review request for mesos, Benjamin Mahler and Kapil Arya. > > > Bugs: MESOS-6976 > https://issues.apache.org/jira/browse/MESOS-6976 > > > Repository: mesos > > > Description > ------- > > Officially, Mesos 1.0.0 (and newer) masters do not support pre-1.0.0 > Mesos agents. However, we previously allowed old agents to register, > which resulted in several master crashes. As a short-term solution, we > fixed those crashes by adding backward compatibility mechanisms into the > master, but that backward compatibility code has made the master logic > more complicated and difficult to understand. > > This commit changes the master to ignore registration attempts by Mesos > agents that precede Mesos 1.0.0. Now that this safety check is in place, > master logic can safely assume that all agents are running at least > Mesos 1.0.0, which will allow several simplifications to be made. > > > Diffs > ----- > > src/master/constants.hpp 7edf9f65f6615b67ad0663f75ea7ee72a6a558cb > src/master/master.cpp 31a7a2fcf905c0c35e80692a69c290d4094deded > src/tests/master_tests.cpp 7cb4774fae1feff007adacf6521fadde2f58bee7 > > > Diff: https://reviews.apache.org/r/58709/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
