----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57935/ -----------------------------------------------------------
(Updated April 27, 2017, 5:35 p.m.) Review request for mesos and Neil Conway. Changes ------- Rebased on top of changes in hierarchical roles implementation. Summary (updated) ----------------- Recalculate shares only when total scalar quantities have changed. Bugs: MESOS-7138 https://issues.apache.org/jira/browse/MESOS-7138 Repository: mesos Description (updated) ------- In `DRFSorter::update`, we should set the `dirty` flag only when the total scalar quantities have changed in any of the cleints in the hierarchy, and not always. Diffs (updated) ----- src/master/allocator/sorter/drf/sorter.hpp fee58d6d1f08163e2a06a4a20c891fe535c3dcff src/master/allocator/sorter/drf/sorter.cpp a8b35c4deac7a4f0725ccae517a8cbca5b8e1ee7 Diff: https://reviews.apache.org/r/57935/diff/2/ Changes: https://reviews.apache.org/r/57935/diff/1-2/ Testing ------- All tests passed. Thanks, Anindya Sinha