> On April 27, 2017, 12:46 a.m., Jie Yu wrote:
> > Do you know if an old registry (< 2.3) will be OK with this header that it
> > does not understand? Can you confirm?
>
> Ilya Pronin wrote:
> Shall we include all content types that we currently support? (Can be
> splitted into multiple `Accept` fields)
> ```
> Accept: application/vnd.docker.distribution.manifest.v1+json,
> application/vnd.docker.distribution.manifest.v1+prettyjws,
> application/json
> ```
>
> Chun-Hung Hsiao wrote:
> I tried but Amazon ECR would reject the header because it's check uses
> the following regex: `\w{1,127}\/[-+.\w]{1,127}]`, so only one MIME type is
> allowed for ECR.
>
> Chun-Hung Hsiao wrote:
> Also, setting `Accept` to just `application/json` would make ECR to
> return a Schema 2 manifest instead of a Schema 1 one.
For ECR, if there is a signed manifest, requesting
`application/vnd.docker.distribution.manifest.v1+json` will receive the signed
one.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58725/#review173140
-----------------------------------------------------------
On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58725/
> -----------------------------------------------------------
>
> (Updated May 1, 2017, 5:24 p.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-7427
> https://issues.apache.org/jira/browse/MESOS-7427
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Accept: application/vnd.docker.distribution.manifest.v1+json'
> to the headers of HTTP requests for fetching manifests from any Docker
> registry. Some registry services (e.g., Amazon ECR) check the 'Accept'
> field strictly and reject the requests if it is not specified.
>
>
> Diffs
> -----
>
> src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90
>
>
> Diff: https://reviews.apache.org/r/58725/diff/3/
>
>
> Testing
> -------
>
> sudo make check
> Manually tested on the following registries:
> 1. Local docker private registries with the following version:
> 2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1
> 2. Amazon ECR repository
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
