----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58725/#review173488 -----------------------------------------------------------
Patch looks great! Reviews applied: [58753, 58725] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 1, 2017, 5:24 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58725/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 5:24 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-7427 > https://issues.apache.org/jira/browse/MESOS-7427 > > > Repository: mesos > > > Description > ------- > > Added 'Accept: application/vnd.docker.distribution.manifest.v1+json' > to the headers of HTTP requests for fetching manifests from any Docker > registry. Some registry services (e.g., Amazon ECR) check the 'Accept' > field strictly and reject the requests if it is not specified. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 1c6ab929deacfc29aa6b4f1df04c2b9782044a90 > > > Diff: https://reviews.apache.org/r/58725/diff/3/ > > > Testing > ------- > > sudo make check > Manually tested on the following registries: > 1. Local docker private registries with the following version: > 2.0.1, 2.1.1, 2.2.1, 2.3.1, 2.4.1, 2.5.1, 2.6.1 > 2. Amazon ECR repository > > > Thanks, > > Chun-Hung Hsiao > >
