----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review173514 -----------------------------------------------------------
include/mesos/secret/secretfetcher.hpp Lines 27 (patched) <https://reviews.apache.org/r/58759/#comment246504> Should this be just called `Fetcher` since it is in the `secret` namespace already? Looks like this is how URI, APPC etc fetchers are named. - Vinod Kone On April 28, 2017, 6:50 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58759/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 6:50 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Introduced SecretFetcher module interface. > > > Diffs > ----- > > include/mesos/module/secretfetcher.hpp PRE-CREATION > include/mesos/secret/secretfetcher.hpp PRE-CREATION > src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 > src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 > > > Diff: https://reviews.apache.org/r/58759/diff/2/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
