----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58759/#review174238 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/module.hpp Lines 113 (patched) <https://reviews.apache.org/r/58759/#comment247349> s/to during/during/ ? include/mesos/secret/resolver.hpp Lines 30 (patched) <https://reviews.apache.org/r/58759/#comment247350> s/::value/::Value/ include/mesos/secret/resolver.hpp Lines 31 (patched) <https://reviews.apache.org/r/58759/#comment247351> s/cannot/secret cannot/ include/mesos/secret/resolver.hpp Lines 41 (patched) <https://reviews.apache.org/r/58759/#comment247352> s/instanciated/instantiated/ include/mesos/secret/resolver.hpp Lines 42-47 (patched) <https://reviews.apache.org/r/58759/#comment247353> Do we typically talk about default implementations here? include/mesos/secret/resolver.hpp Lines 54 (patched) <https://reviews.apache.org/r/58759/#comment247354> s/to a/a/ - Vinod Kone On May 8, 2017, 10:19 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58759/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 10:19 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-7418 > https://issues.apache.org/jira/browse/MESOS-7418 > > > Repository: mesos > > > Description > ------- > > Introduced SecretResolver module interface. > > > Diffs > ----- > > include/mesos/module.hpp c28d01df54906b2b8ebfe7ac9e719a0d1be45614 > include/mesos/module/secret_resolver.hpp PRE-CREATION > include/mesos/secret/resolver.hpp PRE-CREATION > src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a > src/module/manager.cpp 7d875fcb7fcec0d57274e644b0a3b67b333ac193 > > > Diff: https://reviews.apache.org/r/58759/diff/6/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
