> On May 1, 2017, 10:45 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js > > Lines 906 (patched) > > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line906> > > > > Should this be called "update"? It looks to me like it's responsible > > for redirecting. > > > > Also, like Tomasz pointed out, I can't really tell what the if > > condition below does to fix the problem. Would you mind spelling out the > > problem and the fix in the description?
Fixed, thank you. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58872/#review173525 ----------------------------------------------------------- On May 3, 2017, 4:15 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58872/ > ----------------------------------------------------------- > > (Updated May 3, 2017, 4:15 a.m.) > > > Review request for mesos, Benjamin Mahler and Tomasz Janiszewski. > > > Bugs: MESOS-4992 > https://issues.apache.org/jira/browse/MESOS-4992 > > > Repository: mesos > > > Description > ------- > > Open sandbox link in a new tab would fail since it depends on agents > information loading finish. This patch fixes it by ensuring the agents > information loaded first and then rerouting the sandbox request. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > a021962573d452de1581e6a7717016eac7d0cd85 > > > Diff: https://reviews.apache.org/r/58872/diff/2/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
