----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/#review174168 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/mesos.proto Line 107 (original), 107-116 (patched) <https://reviews.apache.org/r/58949/#comment247284> I'll move this right below `SlaveInfo` for consistency. Looks like for the proto file, we use logical grouping. We put ID and basic type definitions first, and then the rest. include/mesos/v1/mesos.proto Lines 112 (patched) <https://reviews.apache.org/r/58949/#comment247288> Ditto on ordering. src/common/type_utils.cpp Lines 372-377 (patched) <https://reviews.apache.org/r/58949/#comment247285> Let's don't introduce this yet until it's actually being used. For that reason, we don't have that for AgentInfo in v1. src/v1/mesos.cpp Lines 346-353 (original), 346-354 (patched) <https://reviews.apache.org/r/58949/#comment247286> Can you swap the ordering between these two? Make sure the order in the cpp file is consistent with that in the header. src/v1/mesos.cpp Lines 374-379 (patched) <https://reviews.apache.org/r/58949/#comment247287> Ditto. Remove - Jie Yu On May 8, 2017, 2:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58949/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 2:49 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7388 > https://issues.apache.org/jira/browse/MESOS-7388 > > > Repository: mesos > > > Description > ------- > > Introduced ResourceProviderInfo proto. > > > Diffs > ----- > > include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 > include/mesos/type_utils.hpp 4f0a59cf7bc4172eb98db01cf73bf285c931b4d0 > include/mesos/v1/mesos.hpp e665ce7046eb6e9c4f0e896e4f8cf9e976c40454 > include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 > src/common/type_utils.cpp 6bfb558d9f7dcdf921acdf737515a25c3a0bdaa0 > src/v1/mesos.cpp babe39e0e29ae7ff35360d9dfdabf771fdc940ea > > > Diff: https://reviews.apache.org/r/58949/diff/2/ > > > Testing > ------- > > `make check` (Fedora25, clang-5) > > > Thanks, > > Benjamin Bannier > >
