> On May 8, 2017, 4:59 p.m., Jie Yu wrote: > > src/common/type_utils.cpp > > Lines 372-377 (patched) > > <https://reviews.apache.org/r/58949/diff/2/?file=1710389#file1710389line372> > > > > Let's don't introduce this yet until it's actually being used. For that > > reason, we don't have that for AgentInfo in v1.
I believe we should add this particular operator just for symmetry. `operator==` will immediately be useful to the first users. > On May 8, 2017, 4:59 p.m., Jie Yu wrote: > > src/v1/mesos.cpp > > Lines 374-379 (patched) > > <https://reviews.apache.org/r/58949/diff/2/?file=1710390#file1710390line374> > > > > Ditto. Remove Ditto. See above. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58949/#review174168 ----------------------------------------------------------- On May 8, 2017, 4:49 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58949/ > ----------------------------------------------------------- > > (Updated May 8, 2017, 4:49 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7388 > https://issues.apache.org/jira/browse/MESOS-7388 > > > Repository: mesos > > > Description > ------- > > Introduced ResourceProviderInfo proto. > > > Diffs > ----- > > include/mesos/mesos.proto 1935f47a52840f6b395ecb2d28296666551fa691 > include/mesos/type_utils.hpp 4f0a59cf7bc4172eb98db01cf73bf285c931b4d0 > include/mesos/v1/mesos.hpp e665ce7046eb6e9c4f0e896e4f8cf9e976c40454 > include/mesos/v1/mesos.proto c7f0bec5c96f2f41344d4261d0696f9fe0421db7 > src/common/type_utils.cpp 6bfb558d9f7dcdf921acdf737515a25c3a0bdaa0 > src/v1/mesos.cpp babe39e0e29ae7ff35360d9dfdabf771fdc940ea > > > Diff: https://reviews.apache.org/r/58949/diff/2/ > > > Testing > ------- > > `make check` (Fedora25, clang-5) > > > Thanks, > > Benjamin Bannier > >
