> On May 9, 2017, 12:19 a.m., Jie Yu wrote: > > As we discussed offline, let's not mess the URI struct. Instead, passing > > the secret to the fetcher using an function parameter in the `fetch` > > method. This will be useful in the future also because fetcher other URIs > > might need secret as well.
Yep, this is fixed in patch /59141. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59015/#review174270 ----------------------------------------------------------- On May 10, 2017, 5:47 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59015/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 5:47 a.m.) > > > Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7088 > https://issues.apache.org/jira/browse/MESOS-7088 > > > Repository: mesos > > > Description > ------- > > Implemented passing docker config depended methods. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b > > > Diff: https://reviews.apache.org/r/59015/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
